Feature/docker validate sha #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
bdf4685 to
7da3389
Compare
This was referenced May 11, 2025
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
d8dddd7 to
bdf4685
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
bdf4685 to
fe001f2
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
c65e6ae to
333c9f5
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
333c9f5 to
17a5ce9
Compare
bhanurp
requested changes
May 22, 2025
| @@ -91,10 +92,23 @@ func (builder *buildInfoBuilder) getSearchableRepo() string { | |||
|
|
|||
| // Set build properties on image layers in Artifactory. | |||
| func setBuildProperties(buildName, buildNumber, project string, imageLayers []utils.ResultItem, serviceManager artifactory.ArtifactoryServicesManager) (err error) { | |||
| // Skip if no build info is provided | |||
| if buildName == "" || buildNumber == "" { | |||
| log.Debug("Skipping setting properties - no build name or build number provided") | |||
There was a problem hiding this comment.
Suggested change
| log.Debug("Skipping setting properties - no build name or build number provided") | |
| log.Debug("Skipping setting properties - build name and build number are required") |
updated debug log message
| log.Warn("Manifest digest mismatch detected. Local image digest: " + rabib.manifestSha2 + ", Repository digest: " + manifestDigest) | ||
| log.Info("Proceeding with SHA-based validation to ensure correct image identification...") | ||
| // Return nil instead of error to allow the operation to continue | ||
| return nil |
There was a problem hiding this comment.
why is the error always nil, if it is has to be nil always remove return type as error in this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--validate-shaflag for Docker push commandDescription
This PR adds core support for the new
--validate-shaflag in the Docker push command. When enabled, the flag allows the CLI to use the image's SHA digest for validation instead of the tag name during Docker push operations. This is particularly useful when pushing to virtual repositories where the tag might exist with different content in higher priority repositories.Changes
artifactory/utils/container/remoteagent.goto handle manifest digest mismatches gracefully--validate-shaflagTesting
Related PRs